abbyswag/qwen-code
1
0
Fork 0
mirror of https://github.com/QwenLM/qwen-code.git synced 2025-12-19 09:33:53 +00:00
Code Issues Packages Projects Releases Wiki Activity

Re-enable backticks in shell tool usage. (#3360)

Browse Source
This commit is contained in:
N. Taylor Mullen
2025-07-07 09:15:10 -07:00
committed by GitHub
parent 48ebd728b3
commit 17dfa267d5
2 changed files with 2 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
packages/core/src/tools/shell.test.ts
View File

@@ -350,17 +350,14 @@ describe('ShellTool', () => {
expect(result.allowed).toBe(true);
});
it('should block a command with command substitution using backticks', async () => {
it('should allow a command with command substitution using backticks', async () => {
const config = {
getCoreTools: () => ['run_shell_command(echo)'],
getExcludeTools: () => [],
} as unknown as Config;
const shellTool = new ShellTool(config);
const result = shellTool.isCommandAllowed('echo `rm -rf /`');
expect(result.allowed).toBe(false);
expect(result.reason).toBe(
'Command substitution using backticks is not allowed for security reasons',
);
expect(result.allowed).toBe(true);
});
it('should block a command with command substitution using $()', async () => {