fix(cli): correctly handle tool invocation cancellation (#844)

This commit is contained in:
N. Taylor Mullen
2025-06-08 11:14:45 -07:00
committed by GitHub
parent 9efca40dae
commit 241c404573
6 changed files with 156 additions and 4 deletions

View File

@@ -19,7 +19,7 @@ import {
ToolCallRequestInfo,
logUserPrompt,
} from '@gemini-cli/core';
import { type PartListUnion } from '@google/genai';
import { type Part, type PartListUnion } from '@google/genai';
import {
StreamingState,
HistoryItemWithoutId,
@@ -531,6 +531,41 @@ export const useGeminiStream = (
completedAndReadyToSubmitTools.length > 0 &&
completedAndReadyToSubmitTools.length === toolCalls.length
) {
// If all the tools were cancelled, don't submit a response to Gemini.
const allToolsCancelled = completedAndReadyToSubmitTools.every(
(tc) => tc.status === 'cancelled',
);
if (allToolsCancelled) {
if (geminiClient) {
// We need to manually add the function responses to the history
// so the model knows the tools were cancelled.
const responsesToAdd = completedAndReadyToSubmitTools.flatMap(
(toolCall) => toolCall.response.responseParts,
);
for (const response of responsesToAdd) {
let parts: Part[];
if (Array.isArray(response)) {
parts = response;
} else if (typeof response === 'string') {
parts = [{ text: response }];
} else {
parts = [response];
}
geminiClient.addHistory({
role: 'user',
parts,
});
}
}
const callIdsToMarkAsSubmitted = completedAndReadyToSubmitTools.map(
(toolCall) => toolCall.request.callId,
);
markToolsAsSubmitted(callIdsToMarkAsSubmitted);
return;
}
const responsesToSend: PartListUnion[] =
completedAndReadyToSubmitTools.map(
(toolCall) => toolCall.response.responseParts,
@@ -542,7 +577,14 @@ export const useGeminiStream = (
markToolsAsSubmitted(callIdsToMarkAsSubmitted);
submitQuery(mergePartListUnions(responsesToSend));
}
}, [toolCalls, isResponding, submitQuery, markToolsAsSubmitted, addItem]);
}, [
toolCalls,
isResponding,
submitQuery,
markToolsAsSubmitted,
addItem,
geminiClient,
]);
const pendingHistoryItems = [
pendingHistoryItemRef.current,