From 2e3eeaf920f51e93d194e36bdd8338e65061afc0 Mon Sep 17 00:00:00 2001 From: Taylor Mullen Date: Sun, 25 May 2025 13:44:49 -0700 Subject: [PATCH] Upon finding > 1 occurrences do not attempt auto-correction. - When correcting edits prior to this if we found more than one occurrence we would try to auto-correct the old/new strings. There's no need in this situation because the tool has already provided too vague of an old_string to act upon. Instantly return. Part of https://github.com/google-gemini/gemini-cli/issues/484 --- packages/server/src/utils/editCorrector.ts | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/packages/server/src/utils/editCorrector.ts b/packages/server/src/utils/editCorrector.ts index c8a8e1a9..477b2381 100644 --- a/packages/server/src/utils/editCorrector.ts +++ b/packages/server/src/utils/editCorrector.ts @@ -69,6 +69,12 @@ export async function ensureCorrectEdit( originalParams.new_string, ); } + } else if (occurrences > 1) { + const result: CorrectedEditResult = { + params: { ...originalParams }, + occurrences, + }; + return result; } else { // occurrences is 0 or some other unexpected state initially const unescapedOldStringAttempt = unescapeStringForGeminiBug(