cleanup unused allowBuildArtifacts (#1010)

packages/cli/src/config/config.integration.test.ts

@@ -60,13 +60,11 @@ describe('Configuration Integration Tests', () => {
         targetDir: tempDir,
         debugMode: false,
         fileFilteringRespectGitIgnore: undefined, // Should default to true
-        fileFilteringAllowBuildArtifacts: undefined, // Should default to false
       };
 
       const config = new Config(configParams);
 
       expect(config.getFileFilteringRespectGitIgnore()).toBe(true);
-      expect(config.getFileFilteringAllowBuildArtifacts()).toBe(false);
     });
 
     it('should load custom file filtering settings from configuration', async () => {
@@ -78,13 +76,11 @@ describe('Configuration Integration Tests', () => {
         targetDir: tempDir,
         debugMode: false,
         fileFilteringRespectGitIgnore: false,
-        fileFilteringAllowBuildArtifacts: true,
       };
 
       const config = new Config(configParams);
 
       expect(config.getFileFilteringRespectGitIgnore()).toBe(false);
-      expect(config.getFileFilteringAllowBuildArtifacts()).toBe(true);
     });
 
     it('should merge user and workspace file filtering settings', async () => {
@@ -96,12 +92,10 @@ describe('Configuration Integration Tests', () => {
         targetDir: tempDir,
         debugMode: false,
         fileFilteringRespectGitIgnore: true,
-        fileFilteringAllowBuildArtifacts: true,
       };
 
       const config = new Config(configParams);
 
-      expect(config.getFileFilteringAllowBuildArtifacts()).toBe(true);
       expect(config.getFileFilteringRespectGitIgnore()).toBe(true);
     });
   });
@@ -116,16 +110,12 @@ describe('Configuration Integration Tests', () => {
         targetDir: tempDir,
         debugMode: false,
         fileFilteringRespectGitIgnore: false,
-        fileFilteringAllowBuildArtifacts: undefined, // Should default to false
       };
 
       const config = new Config(configParams);
 
       // Specified settings should be applied
       expect(config.getFileFilteringRespectGitIgnore()).toBe(false);
-
-      // Missing settings should use defaults
-      expect(config.getFileFilteringAllowBuildArtifacts()).toBe(false);
     });
 
     it('should handle empty configuration objects gracefully', async () => {
@@ -137,14 +127,12 @@ describe('Configuration Integration Tests', () => {
         targetDir: tempDir,
         debugMode: false,
         fileFilteringRespectGitIgnore: undefined,
-        fileFilteringAllowBuildArtifacts: undefined,
       };
 
       const config = new Config(configParams);
 
       // All settings should use defaults
       expect(config.getFileFilteringRespectGitIgnore()).toBe(true);
-      expect(config.getFileFilteringAllowBuildArtifacts()).toBe(false);
     });
 
     it('should handle missing configuration sections gracefully', async () => {
@@ -162,7 +150,6 @@ describe('Configuration Integration Tests', () => {
 
       // All git-aware settings should use defaults
       expect(config.getFileFilteringRespectGitIgnore()).toBe(true);
-      expect(config.getFileFilteringAllowBuildArtifacts()).toBe(false);
     });
   });
 
@@ -176,30 +163,11 @@ describe('Configuration Integration Tests', () => {
         targetDir: tempDir,
         debugMode: false,
         fileFilteringRespectGitIgnore: true,
-        fileFilteringAllowBuildArtifacts: false,
       };
 
       const config = new Config(configParams);
 
       expect(config.getFileFilteringRespectGitIgnore()).toBe(true);
-      expect(config.getFileFilteringAllowBuildArtifacts()).toBe(false);
-    });
-
-    it('should handle a development-focused configuration', async () => {
-      const configParams: ConfigParameters = {
-        cwd: '/tmp',
-        contentGeneratorConfig: TEST_CONTENT_GENERATOR_CONFIG,
-        embeddingModel: 'test-embedding-model',
-        sandbox: false,
-        targetDir: tempDir,
-        debugMode: false,
-        fileFilteringRespectGitIgnore: true,
-        fileFilteringAllowBuildArtifacts: true,
-      };
-
-      const config = new Config(configParams);
-
-      expect(config.getFileFilteringAllowBuildArtifacts()).toBe(true);
     });
 
     it('should handle a CI/CD environment configuration', async () => {
@@ -211,13 +179,11 @@ describe('Configuration Integration Tests', () => {
         targetDir: tempDir,
         debugMode: false,
         fileFilteringRespectGitIgnore: false, // CI might need to see all files
-        fileFilteringAllowBuildArtifacts: true,
       };
 
       const config = new Config(configParams);
 
       expect(config.getFileFilteringRespectGitIgnore()).toBe(false);
-      expect(config.getFileFilteringAllowBuildArtifacts()).toBe(true);
     });
   });
 });

packages/cli/src/config/config.ts

@@ -195,8 +195,6 @@ export async function loadCliConfig(
         : (settings.telemetry ?? false),
     // Git-aware file filtering settings
     fileFilteringRespectGitIgnore: settings.fileFiltering?.respectGitIgnore,
-    fileFilteringAllowBuildArtifacts:
-      settings.fileFiltering?.allowBuildArtifacts,
     checkpoint: argv.checkpoint,
     proxy:
       process.env.HTTPS_PROXY ||

packages/cli/src/config/settings.ts

@@ -43,7 +43,6 @@ export interface Settings {
   // Git-aware file filtering settings
   fileFiltering?: {
     respectGitIgnore?: boolean;
-    allowBuildArtifacts?: boolean;
   };
 
   // UI setting. Does not display the ANSI-controlled terminal title.

packages/cli/src/ui/hooks/atCommandProcessor.test.ts

@@ -21,7 +21,6 @@ const mockConfig = {
   isSandboxed: vi.fn(() => false),
   getFileService: vi.fn(),
   getFileFilteringRespectGitIgnore: vi.fn(() => true),
-  getFileFilteringAllowBuildArtifacts: vi.fn(() => false),
 } as unknown as Config;
 
 const mockReadManyFilesExecute = vi.fn();

packages/cli/src/ui/hooks/useCompletion.integration.test.ts

@@ -47,7 +47,6 @@ describe('useCompletion git-aware filtering integration', () => {
 
     mockConfig = {
       getFileFilteringRespectGitIgnore: vi.fn(() => true),
-      getFileFilteringAllowBuildArtifacts: vi.fn(() => false),
       getFileService: vi.fn().mockResolvedValue(mockFileDiscoveryService),
     };