From 50d5cc2f6a4b3449fa70e7312ac9881b33124e85 Mon Sep 17 00:00:00 2001 From: pomelo-nwu Date: Fri, 31 Oct 2025 17:00:28 +0800 Subject: [PATCH] fix: handle AbortError gracefully when loading commands --- .../src/services/FileCommandLoader.test.ts | 24 +++++++++++++++++++ .../cli/src/services/FileCommandLoader.ts | 6 ++++- 2 files changed, 29 insertions(+), 1 deletion(-) diff --git a/packages/cli/src/services/FileCommandLoader.test.ts b/packages/cli/src/services/FileCommandLoader.test.ts index 7713775c..50c85e66 100644 --- a/packages/cli/src/services/FileCommandLoader.test.ts +++ b/packages/cli/src/services/FileCommandLoader.test.ts @@ -1227,4 +1227,28 @@ describe('FileCommandLoader', () => { expect(commands).toHaveLength(0); }); }); + + describe('AbortError handling', () => { + it('should silently ignore AbortError when operation is cancelled', async () => { + const userCommandsDir = Storage.getUserCommandsDir(); + mock({ + [userCommandsDir]: { + 'test1.toml': 'prompt = "Prompt 1"', + 'test2.toml': 'prompt = "Prompt 2"', + }, + }); + + const loader = new FileCommandLoader(null); + const controller = new AbortController(); + const signal = controller.signal; + + // Start loading and immediately abort + const loadPromise = loader.loadCommands(signal); + controller.abort(); + + // Should not throw or print errors + const commands = await loadPromise; + expect(commands).toHaveLength(0); + }); + }); }); diff --git a/packages/cli/src/services/FileCommandLoader.ts b/packages/cli/src/services/FileCommandLoader.ts index fe485fa2..5527aa80 100644 --- a/packages/cli/src/services/FileCommandLoader.ts +++ b/packages/cli/src/services/FileCommandLoader.ts @@ -120,7 +120,11 @@ export class FileCommandLoader implements ICommandLoader { // Add all commands without deduplication allCommands.push(...commands); } catch (error) { - if ((error as NodeJS.ErrnoException).code !== 'ENOENT') { + // Ignore ENOENT (directory doesn't exist) and AbortError (operation was cancelled) + const isEnoent = (error as NodeJS.ErrnoException).code === 'ENOENT'; + const isAbortError = + error instanceof Error && error.name === 'AbortError'; + if (!isEnoent && !isAbortError) { console.error( `[FileCommandLoader] Error loading commands from ${dirInfo.path}:`, error,