abbyswag/qwen-code
1
0
Fork 0
mirror of https://github.com/QwenLM/qwen-code.git synced 2025-12-20 16:57:46 +00:00
Code Issues Packages Projects Releases Wiki Activity

Remove redundant else branches (#86)

Browse Source 
Else branches are an anti pattern especially if you can easily return from the previous branch. Over time, else branches cause deep nesting and make code unreadable and unmaintainable. Remove elses where possible.
This commit is contained in:
Jaana Dogan
2025-04-21 12:15:47 -07:00
committed by GitHub
parent dea0782c89
commit 53a5728009
5 changed files with 59 additions and 61 deletions
Download Patch File Download Diff File Expand all files Collapse all files

27
packages/cli/src/gemini.ts
View File

@@ -54,20 +54,21 @@ process.on('unhandledRejection', (reason, _promise) => {
);
console.warn('-----------------------------------------');
console.warn('Reason:', reason);
// No process.exit(1);
} else {
// Log other unexpected unhandled rejections as critical errors
console.error('=========================================');
console.error('CRITICAL: Unhandled Promise Rejection!');
console.error('=========================================');
console.error('Reason:', reason);
console.error('Stack trace may follow:');
if (!(reason instanceof Error)) {
console.error(reason);
}
// Exit for genuinely unhandled errors
process.exit(1);
return;
// No process.exit(1); Don't exit.
}
// Log other unexpected unhandled rejections as critical errors
console.error('=========================================');
console.error('CRITICAL: Unhandled Promise Rejection!');
console.error('=========================================');
console.error('Reason:', reason);
console.error('Stack trace may follow:');
if (!(reason instanceof Error)) {
console.error(reason);
}
// Exit for genuinely unhandled errors
process.exit(1);
});
// --- Global Entry Point ---

10
packages/cli/src/ui/hooks/useStdin.ts
View File

@@ -70,13 +70,13 @@ export function usePipedInput(): PipedInputState {
stdin.removeListener('error', handleError);
stdin.removeListener('end', handleEnd);
};
} else {
// No piped input (running interactively)
setIsLoading(false);
// Optionally set an 'info' state or just let isLoading=false & isPiped=false suffice
// setError('No piped input detected.'); // Maybe don't treat this as an 'error'
}
// No piped input (running interactively)
setIsLoading(false);
// Optionally set an 'info' state or just let isLoading=false & isPiped=false suffice
// setError('No piped input detected.'); // Maybe don't treat this as an 'error'
// Intentionally run only once on mount or when stdin theoretically changes
}, [stdin, isRawModeSupported, setRawMode /*, exit */]);