abbyswag/qwen-code
1
0
Fork 0
mirror of https://github.com/QwenLM/qwen-code.git synced 2025-12-21 17:27:54 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix: resolve EditTool naming inconsistency causing agent confusion loops (#513)

Browse Source 
* fix: resolve EditTool naming inconsistency causing agent confusion loops

* docs: restore original format for edit tool

* fix: apply prettier formatting to docs and tests

* test: update snapshots for edit tool
This commit is contained in:
Zagorulko Oleg
2025-09-09 06:33:07 +03:00
committed by GitHub
parent dded10f98c
commit 60c136ad67
10 changed files with 44 additions and 48 deletions
Download Patch File Download Diff File Expand all files Collapse all files

22
integration-tests/replace.test.ts → integration-tests/edit.test.ts
View File

@@ -7,34 +7,34 @@
import { describe, it, expect, vi } from 'vitest';
import { TestRig, printDebugInfo, validateModelOutput } from './test-helper.js';
describe('replace', () => {
it('should be able to replace content in a file', async () => {
describe('edit', () => {
it('should be able to edit content in a file', async () => {
const rig = new TestRig();
await rig.setup('should be able to replace content in a file');
await rig.setup('should be able to edit content in a file');
const fileName = 'file_to_replace.txt';
const fileName = 'file_to_edit.txt';
const originalContent = 'original content';
const expectedContent = 'replaced content';
const expectedContent = 'edited content';
rig.createFile(fileName, originalContent);
const prompt = `Can you replace 'original' with 'replaced' in the file 'file_to_replace.txt'`;
const prompt = `Can you edit the file 'file_to_edit.txt' to change 'original' to 'edited'`;
const result = await rig.run(prompt);
const foundToolCall = await rig.waitForToolCall('replace');
const foundToolCall = await rig.waitForToolCall('edit');
// Add debugging information
if (!foundToolCall) {
printDebugInfo(rig, result);
}
expect(foundToolCall, 'Expected to find a replace tool call').toBeTruthy();
expect(foundToolCall, 'Expected to find an edit tool call').toBeTruthy();
// Validate model output - will throw if no output, warn if missing expected content
validateModelOutput(
result,
['replaced', 'file_to_replace.txt'],
'Replace content test',
['edited', 'file_to_edit.txt'],
'Edit content test',
);
const newFileContent = rig.readFile(fileName);
@@ -58,7 +58,7 @@ describe('replace', () => {
// Log success info if verbose
vi.stubEnv('VERBOSE', 'true');
if (process.env['VERBOSE'] === 'true') {
console.log('File replaced successfully. New content:', newFileContent);
console.log('File edited successfully. New content:', newFileContent);
}
});
});

8
integration-tests/file-system.test.ts
View File

@@ -44,11 +44,7 @@ describe('file-system', () => {
const result = await rig.run(`edit test.txt to have a hello world message`);
// Accept multiple valid tools for editing files
const foundToolCall = await rig.waitForAnyToolCall([
'write_file',
'edit',
'replace',
]);
const foundToolCall = await rig.waitForAnyToolCall(['write_file', 'edit']);
// Add debugging information
if (!foundToolCall) {
@@ -57,7 +53,7 @@ describe('file-system', () => {
expect(
foundToolCall,
'Expected to find a write_file, edit, or replace tool call',
'Expected to find a write_file or edit tool call',
).toBeTruthy();
// Validate model output - will throw if no output