From 6aaac12d70e6cd589c75a6070290016ad13377c6 Mon Sep 17 00:00:00 2001 From: Matthieu Beaumont Date: Sat, 8 Nov 2025 14:54:43 +0100 Subject: [PATCH] fix(acp): replace EOL with newline for content splitting - Replace `EOL` from `node:os` with `\n` for consistent line splitting in ACP connection output processing - This ensures cross-platform compatibility since `EOL` is platform-specific while `\n` is universally used in text decoding - The change maintains the same behavior on all platforms by using standard newline characters --- packages/cli/src/zed-integration/acp.ts | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/packages/cli/src/zed-integration/acp.ts b/packages/cli/src/zed-integration/acp.ts index 74f97cc6..a260c61e 100644 --- a/packages/cli/src/zed-integration/acp.ts +++ b/packages/cli/src/zed-integration/acp.ts @@ -7,7 +7,6 @@ /* ACP defines a schema for a simple (experimental) JSON-RPC protocol that allows GUI applications to interact with agents. */ import { z } from 'zod'; -import { EOL } from 'node:os'; import * as schema from './schema.js'; export * from './schema.js'; @@ -173,7 +172,7 @@ class Connection { const decoder = new TextDecoder(); for await (const chunk of output) { content += decoder.decode(chunk, { stream: true }); - const lines = content.split(EOL); + const lines = content.split('\n'); content = lines.pop() || ''; for (const line of lines) {