Use yargs array type for the allowedMcpServerNames flag instead of processing the list directly ourselves. (#3600)

This commit is contained in:
Tyler
2025-07-09 11:38:38 -07:00
committed by GitHub
parent 017a0a6c86
commit 6c12f9e0d9
2 changed files with 12 additions and 9 deletions

View File

@@ -527,7 +527,9 @@ describe('loadCliConfig with allowed-mcp-server-names', () => {
'node',
'script.js',
'--allowed-mcp-server-names',
'server1,server3',
'server1',
'--allowed-mcp-server-names',
'server3',
];
const config = await loadCliConfig(baseSettings, [], 'test-session');
expect(config.getMcpServers()).toEqual({
@@ -541,7 +543,9 @@ describe('loadCliConfig with allowed-mcp-server-names', () => {
'node',
'script.js',
'--allowed-mcp-server-names',
'server1,server4',
'server1',
'--allowed-mcp-server-names',
'server4',
];
const config = await loadCliConfig(baseSettings, [], 'test-session');
expect(config.getMcpServers()).toEqual({
@@ -549,10 +553,10 @@ describe('loadCliConfig with allowed-mcp-server-names', () => {
});
});
it('should allow all MCP servers if the flag is an empty string', async () => {
it('should allow no MCP servers if the flag is provided but empty', async () => {
process.argv = ['node', 'script.js', '--allowed-mcp-server-names', ''];
const config = await loadCliConfig(baseSettings, [], 'test-session');
expect(config.getMcpServers()).toEqual(baseSettings.mcpServers);
expect(config.getMcpServers()).toEqual({});
});
});