more consistent confirmations, TODO to improve write confirmations, drop "description" from execution confirmation, add confirmation to new (still dummy) shell tool (#176)

This commit is contained in:
Olcan
2025-04-25 14:05:58 -07:00
committed by GitHub
parent 1a64268bb0
commit 7087c0508e
5 changed files with 51 additions and 21 deletions

View File

@@ -253,12 +253,10 @@ Use this tool for running build steps (\`npm install\`, \`make\`), linters (\`es
if (this.shouldAlwaysExecuteCommands.get(rootCommand)) {
return false;
}
const description = this.getDescription(params);
const confirmationDetails: ToolExecuteConfirmationDetails = {
title: 'Confirm Shell Command',
command: params.command,
rootCommand,
description: `Execute in '${this.currentCwd}':\n${description}`,
onConfirm: async (outcome: ToolConfirmationOutcome) => {
if (outcome === ToolConfirmationOutcome.ProceedAlways) {
this.shouldAlwaysExecuteCommands.set(rootCommand, true);