abbyswag/qwen-code
1
0
Fork 0
mirror of https://github.com/QwenLM/qwen-code.git synced 2025-12-20 16:57:46 +00:00
Code Issues Packages Projects Releases Wiki Activity

Enable tool call type coersion (#477)

Browse Source 
* feat: enable tool call type coercion

* fix: tests for type coercion

---------

Co-authored-by: Mingholy <mingholy.lmh@gmail.com>
This commit is contained in:
Peter Stewart
2025-09-18 15:04:27 +10:00
committed by GitHub
parent 17cdce6298
commit 724c24933c
4 changed files with 36 additions and 23 deletions
Download Patch File Download Diff File Expand all files Collapse all files

21
packages/core/src/tools/glob.test.ts
View File

@@ -62,6 +62,9 @@ describe('GlobTool', () => {
// Ensure a noticeable difference in modification time
await new Promise((resolve) => setTimeout(resolve, 50));
await fs.writeFile(path.join(tempRootDir, 'newer.sortme'), 'newer_content');
// For type coercion testing
await fs.mkdir(path.join(tempRootDir, '123'));
});
afterEach(async () => {
@@ -279,26 +282,20 @@ describe('GlobTool', () => {
);
});
it('should return error if path is provided but is not a string (schema validation)', () => {
it('should pass if path is provided but is not a string (type coercion)', () => {
const params = {
pattern: '*.ts',
path: 123,
};
// @ts-expect-error - We're intentionally creating invalid params for testing
expect(globTool.validateToolParams(params)).toBe(
'params/path must be string',
);
} as unknown as GlobToolParams; // Force incorrect type
expect(globTool.validateToolParams(params)).toBeNull();
});
it('should return error if case_sensitive is provided but is not a boolean (schema validation)', () => {
it('should pass if case_sensitive is provided but is not a boolean (type coercion)', () => {
const params = {
pattern: '*.ts',
case_sensitive: 'true',
};
// @ts-expect-error - We're intentionally creating invalid params for testing
expect(globTool.validateToolParams(params)).toBe(
'params/case_sensitive must be boolean',
);
} as unknown as GlobToolParams; // Force incorrect type
expect(globTool.validateToolParams(params)).toBeNull();
});
it("should return error if search path resolves outside the tool's root directory", () => {