abbyswag/qwen-code
1
0
Fork 0
mirror of https://github.com/QwenLM/qwen-code.git synced 2025-12-19 09:33:53 +00:00
Code Issues Packages Projects Releases Wiki Activity

don't confirm invalid params in terminal tool, or in general (added comments to base class) (#187)

Browse Source
This commit is contained in:
Olcan
2025-04-27 10:25:12 -07:00
committed by GitHub
parent 7828e813a8
commit 9de2e82b8f
2 changed files with 7 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
packages/server/src/tools/terminal.ts
View File

@@ -244,6 +244,9 @@ Use this tool for running build steps (\`npm install\`, \`make\`), linters (\`es
async shouldConfirmExecute( async shouldConfirmExecute(
params: TerminalToolParams, params: TerminalToolParams,
): Promise<ToolCallConfirmationDetails | false> { ): Promise<ToolCallConfirmationDetails | false> {
if (this.validateToolParams(params)) {
return false; // skip confirmation, execute call will fail immediately
}
const rootCommand = const rootCommand =
params.command params.command
.trim() .trim()

4
packages/server/src/tools/tools.ts
View File

@@ -36,6 +36,8 @@ export interface Tool<
/** /**
* Validates the parameters for the tool * Validates the parameters for the tool
* Should be called from both `shouldConfirmExecute` and `execute`
* `shouldConfirmExecute` should return false immediately if invalid
* @param params Parameters to validate * @param params Parameters to validate
* @returns An error message string if invalid, null otherwise * @returns An error message string if invalid, null otherwise
*/ */
@@ -102,6 +104,8 @@ export abstract class BaseTool<
/** /**
* Validates the parameters for the tool * Validates the parameters for the tool
* This is a placeholder implementation and should be overridden * This is a placeholder implementation and should be overridden
* Should be called from both `shouldConfirmExecute` and `execute`
* `shouldConfirmExecute` should return false immediately if invalid
* @param params Parameters to validate * @param params Parameters to validate
* @returns An error message string if invalid, null otherwise * @returns An error message string if invalid, null otherwise
*/ */