abbyswag/qwen-code
1
0
Fork 0
mirror of https://github.com/QwenLM/qwen-code.git synced 2025-12-21 09:17:53 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix bug executing commands in windows whose flags contain spaces (#5317)

Browse Source
This commit is contained in:
Tommaso Sciortino
2025-07-31 17:27:07 -07:00
committed by GitHub
parent 6f7beb414c
commit a3a432e3cf
2 changed files with 26 additions and 15 deletions
Download Patch File Download Diff File Expand all files Collapse all files

30
packages/core/src/services/shellExecutionService.test.ts
View File

@@ -91,9 +91,9 @@ describe('ShellExecutionService', () => {
});
expect(mockSpawn).toHaveBeenCalledWith(
'bash',
['-c', 'ls -l'],
expect.any(Object),
'ls -l',
[],
expect.objectContaining({ shell: 'bash' }),
);
expect(result.exitCode).toBe(0);
expect(result.signal).toBeNull();
@@ -334,23 +334,31 @@ describe('ShellExecutionService', () => {
describe('Platform-Specific Behavior', () => {
it('should use cmd.exe on Windows', async () => {
mockPlatform.mockReturnValue('win32');
await simulateExecution('dir', (cp) => cp.emit('exit', 0, null));
await simulateExecution('dir "foo bar"', (cp) =>
cp.emit('exit', 0, null),
);
expect(mockSpawn).toHaveBeenCalledWith(
'cmd.exe',
['/c', 'dir'],
expect.objectContaining({ detached: false }),
'dir "foo bar"',
[],
expect.objectContaining({
shell: true,
detached: false,
}),
);
});
it('should use bash and detached process group on Linux', async () => {
mockPlatform.mockReturnValue('linux');
await simulateExecution('ls', (cp) => cp.emit('exit', 0, null));
await simulateExecution('ls "foo bar"', (cp) => cp.emit('exit', 0, null));
expect(mockSpawn).toHaveBeenCalledWith(
'bash',
['-c', 'ls'],
expect.objectContaining({ detached: true }),
'ls "foo bar"',
[],
expect.objectContaining({
shell: 'bash',
detached: true,
}),
);
});
});