fix(shell-utils): resolve command detection on Ubuntu by using shell for builtins (#1123)

This commit is contained in:
Zijun Yang
2025-12-01 22:49:40 -05:00
committed by GitHub
parent c9af74816a
commit a7abd8d09f

View File

@@ -517,24 +517,39 @@ export function resolveCommandPath(command: string): {
try {
const isWin = process.platform === 'win32';
const checkCommand = isWin ? 'where' : 'command';
const checkArgs = isWin ? [command] : ['-v', command];
if (isWin) {
const checkCommand = 'where.exe';
const checkArgs = [command];
let result: string | null = null;
try {
result = execFileSync(checkCommand, checkArgs, {
encoding: 'utf8',
shell: isWin,
shell: false,
}).trim();
} catch {
console.warn(`Command ${checkCommand} not found`);
return { path: null, error: undefined };
}
return result ? { path: result } : { path: null };
} else {
const shell = '/bin/sh';
const checkArgs = ['-c', `command -v ${escapeShellArg(command, 'bash')}`];
let result: string | null = null;
try {
result = execFileSync(shell, checkArgs, {
encoding: 'utf8',
shell: false,
}).trim();
} catch {
return { path: null, error: undefined };
}
if (!result) return { path: null, error: undefined };
if (!isWin) {
accessSync(result, fsConstants.X_OK);
}
return { path: result, error: undefined };
}
} catch (error) {
return {
path: null,