From d4fa15dd53a6bc5ec6806b9e32c82cbdc8dd2413 Mon Sep 17 00:00:00 2001
From: Fan <koala99.zf@gmail.com>
Date: Thu, 9 Oct 2025 15:41:57 +0800
Subject: [PATCH] remove topp default value 0.0 (#785)

---
 packages/core/src/core/client.test.ts                     | 4 ----
 packages/core/src/core/client.ts                          | 5 +----
 packages/core/src/core/openaiContentGenerator/pipeline.ts | 6 +++---
 3 files changed, 4 insertions(+), 11 deletions(-)

diff --git a/packages/core/src/core/client.test.ts b/packages/core/src/core/client.test.ts
index 59d4a4c6..11cc1c38 100644
--- a/packages/core/src/core/client.test.ts
+++ b/packages/core/src/core/client.test.ts
@@ -434,8 +434,6 @@ describe('Gemini Client (client.ts)', () => {
           config: {
             abortSignal,
             systemInstruction: getCoreSystemPrompt(''),
-            temperature: 0,
-            topP: 1,
             tools: [
               {
                 functionDeclarations: [
@@ -486,7 +484,6 @@ describe('Gemini Client (client.ts)', () => {
             abortSignal,
             systemInstruction: getCoreSystemPrompt(''),
             temperature: 0.9,
-            topP: 1, // from default
             topK: 20,
             tools: [
               {
@@ -2461,7 +2458,6 @@ ${JSON.stringify(
             abortSignal,
             systemInstruction: getCoreSystemPrompt(''),
             temperature: 0.5,
-            topP: 1,
           },
           contents,
         },
diff --git a/packages/core/src/core/client.ts b/packages/core/src/core/client.ts
index 05be91b6..898cee3a 100644
--- a/packages/core/src/core/client.ts
+++ b/packages/core/src/core/client.ts
@@ -115,10 +115,7 @@ export class GeminiClient {
   private chat?: GeminiChat;
   private contentGenerator?: ContentGenerator;
   private readonly embeddingModel: string;
-  private readonly generateContentConfig: GenerateContentConfig = {
-    temperature: 0,
-    topP: 1,
-  };
+  private readonly generateContentConfig: GenerateContentConfig = {};
   private sessionTurnCount = 0;
 
   private readonly loopDetector: LoopDetectionService;
diff --git a/packages/core/src/core/openaiContentGenerator/pipeline.ts b/packages/core/src/core/openaiContentGenerator/pipeline.ts
index 2ce0e074..6e67d8f0 100644
--- a/packages/core/src/core/openaiContentGenerator/pipeline.ts
+++ b/packages/core/src/core/openaiContentGenerator/pipeline.ts
@@ -302,9 +302,9 @@ export class ContentGenerationPipeline {
     };
 
     const params = {
-      // Parameters with request fallback and defaults
-      temperature: getParameterValue('temperature', 'temperature', 0.0),
-      top_p: getParameterValue('top_p', 'topP', 1.0),
+      // Parameters with request fallback but no defaults
+      ...addParameterIfDefined('temperature', 'temperature', 'temperature'),
+      ...addParameterIfDefined('top_p', 'top_p', 'topP'),
 
       // Max tokens (special case: different property names)
       ...addParameterIfDefined('max_tokens', 'max_tokens', 'maxOutputTokens'),