From 25d9c4f1a7dd36301b44a1061b1ad134cd95abbd Mon Sep 17 00:00:00 2001
From: "mingholy.lmh" <mingholy.lmh@alibaba-inc.com>
Date: Tue, 16 Dec 2025 17:09:42 +0800
Subject: [PATCH] fix: default values of sampling params

---
 packages/core/src/core/baseLlmClient.test.ts | 5 ++---
 packages/core/src/core/baseLlmClient.ts      | 3 +--
 packages/core/src/core/client.test.ts        | 2 +-
 packages/core/src/core/client.ts             | 3 +--
 4 files changed, 5 insertions(+), 8 deletions(-)

diff --git a/packages/core/src/core/baseLlmClient.test.ts b/packages/core/src/core/baseLlmClient.test.ts
index 999a6903..b074e836 100644
--- a/packages/core/src/core/baseLlmClient.test.ts
+++ b/packages/core/src/core/baseLlmClient.test.ts
@@ -151,8 +151,7 @@ describe('BaseLlmClient', () => {
           contents: defaultOptions.contents,
           config: {
             abortSignal: defaultOptions.abortSignal,
-            temperature: 0,
-            topP: 1,
+            topP: 0.8,
             tools: [
               {
                 functionDeclarations: [
@@ -189,7 +188,7 @@ describe('BaseLlmClient', () => {
         expect.objectContaining({
           config: expect.objectContaining({
             temperature: 0.8,
-            topP: 1, // Default should remain if not overridden
+            topP: 0.8, // Default should remain if not overridden
             topK: 10,
             tools: expect.any(Array),
           }),
diff --git a/packages/core/src/core/baseLlmClient.ts b/packages/core/src/core/baseLlmClient.ts
index b8ce2a68..6b87b13d 100644
--- a/packages/core/src/core/baseLlmClient.ts
+++ b/packages/core/src/core/baseLlmClient.ts
@@ -66,8 +66,7 @@ export interface GenerateJsonOptions {
 export class BaseLlmClient {
   // Default configuration for utility tasks
   private readonly defaultUtilityConfig: GenerateContentConfig = {
-    temperature: 0,
-    topP: 1,
+    topP: 0.8,
   };
 
   constructor(
diff --git a/packages/core/src/core/client.test.ts b/packages/core/src/core/client.test.ts
index 8adaf4f6..01374805 100644
--- a/packages/core/src/core/client.test.ts
+++ b/packages/core/src/core/client.test.ts
@@ -2310,7 +2310,7 @@ ${JSON.stringify(
             abortSignal,
             systemInstruction: getCoreSystemPrompt(''),
             temperature: 0.5,
-            topP: 1,
+            topP: 0.8,
           },
           contents,
         },
diff --git a/packages/core/src/core/client.ts b/packages/core/src/core/client.ts
index 6e3be209..38f02099 100644
--- a/packages/core/src/core/client.ts
+++ b/packages/core/src/core/client.ts
@@ -94,8 +94,7 @@ const MAX_TURNS = 100;
 export class GeminiClient {
   private chat?: GeminiChat;
   private readonly generateContentConfig: GenerateContentConfig = {
-    temperature: 0,
-    topP: 1,
+    topP: 0.8,
   };
   private sessionTurnCount = 0;