update /editor to new slash command arch (#4153)

Co-authored-by: Abhi <abhipatel@google.com>
This commit is contained in:
Harold Mciver
2025-07-16 20:27:36 -04:00
committed by GitHub
parent ab9eb9377f
commit fbe09cd35e
7 changed files with 63 additions and 24 deletions

View File

@@ -0,0 +1,30 @@
/**
* @license
* Copyright 2025 Google LLC
* SPDX-License-Identifier: Apache-2.0
*/
import { describe, it, expect } from 'vitest';
import { editorCommand } from './editorCommand.js';
// 1. Import the mock context utility
import { createMockCommandContext } from '../../test-utils/mockCommandContext.js';
describe('editorCommand', () => {
it('should return a dialog action to open the editor dialog', () => {
if (!editorCommand.action) {
throw new Error('The editor command must have an action.');
}
const mockContext = createMockCommandContext();
const result = editorCommand.action(mockContext, '');
expect(result).toEqual({
type: 'dialog',
dialog: 'editor',
});
});
it('should have the correct name and description', () => {
expect(editorCommand.name).toBe('editor');
expect(editorCommand.description).toBe('set external editor preference');
});
});

View File

@@ -0,0 +1,16 @@
/**
* @license
* Copyright 2025 Google LLC
* SPDX-License-Identifier: Apache-2.0
*/
import { type OpenDialogActionReturn, type SlashCommand } from './types.js';
export const editorCommand: SlashCommand = {
name: 'editor',
description: 'set external editor preference',
action: (): OpenDialogActionReturn => ({
type: 'dialog',
dialog: 'editor',
}),
};

View File

@@ -71,8 +71,7 @@ export interface MessageActionReturn {
*/
export interface OpenDialogActionReturn {
type: 'dialog';
// TODO: Add 'theme' | 'auth' | 'editor' | 'privacy' as migration happens.
dialog: 'help' | 'auth' | 'theme' | 'privacy';
dialog: 'help' | 'auth' | 'theme' | 'editor' | 'privacy';
}
/**