update /editor to new slash command arch (#4153)

Co-authored-by: Abhi <abhipatel@google.com>
This commit is contained in:
Harold Mciver
2025-07-16 20:27:36 -04:00
committed by GitHub
parent ab9eb9377f
commit fbe09cd35e
7 changed files with 63 additions and 24 deletions

View File

@@ -206,18 +206,6 @@ describe('useSlashCommandProcessor', () => {
const getProcessor = () => getProcessorHook().result.current;
describe('Other commands', () => {
it('/editor should open editor dialog and return handled', async () => {
const { handleSlashCommand } = getProcessor();
let commandResult: SlashCommandProcessorResult | false = false;
await act(async () => {
commandResult = await handleSlashCommand('/editor');
});
expect(mockOpenEditorDialog).toHaveBeenCalled();
expect(commandResult).toEqual({ type: 'handled' });
});
});
describe('New command registry', () => {
let ActualCommandService: typeof CommandService;

View File

@@ -199,11 +199,6 @@ export const useSlashCommandProcessor = (
const legacyCommands: LegacySlashCommand[] = useMemo(() => {
const commands: LegacySlashCommand[] = [
// `/help` and `/clear` have been migrated and REMOVED from this list.
{
name: 'editor',
description: 'set external editor preference',
action: (_mainCommand, _subCommand, _args) => openEditorDialog(),
},
{
name: 'corgi',
action: (_mainCommand, _subCommand, _args) => {
@@ -425,7 +420,6 @@ export const useSlashCommandProcessor = (
return commands;
}, [
addMessage,
openEditorDialog,
toggleCorgiMode,
config,
session,
@@ -519,6 +513,9 @@ export const useSlashCommandProcessor = (
case 'theme':
openThemeDialog();
return { type: 'handled' };
case 'editor':
openEditorDialog();
return { type: 'handled' };
case 'privacy':
openPrivacyNotice();
return { type: 'handled' };
@@ -617,6 +614,7 @@ export const useSlashCommandProcessor = (
addMessage,
openThemeDialog,
openPrivacyNotice,
openEditorDialog,
],
);